launchpad-reviewers team mailing list archive

[Tushar Gupta <mp+482782@xxxxxxxxxxxxxxxxxx>]

Thanks for the MP. 

> what i'm unfamiliar with is the isolation between lxd container running the build and the build context (chroot?)

Not sure if I understand this correctly, but "buildd" LXD images (which we also refer to as chroots) that are built by CPC are used to create LXD containers (backend) and within that the build commands are executed. 

> If there is a chance of sources.list being made available to the OCI being built, adding the following lines after installing docker.io

I think it depends on the Dockerfile being specified. The command to build is basically "docker build --no-cache <other-args>" at lpbuildd/target/build_oci.py:L109. Also, I suspect it won't matter because we any way override the sources list to point to "http://ftpmaster.internal"; (Example build log: https://qastaging.launchpadlibrarian.net/774966671/buildlog_oci_ubuntu_focal_amd64_oci-tushar-recipe_BUILDING.txt.gz - I need to double-check on this with the team again)

> 2. I am operating under the assumption that the build backend (lxd) is ephemeral and fully removed between builds on a node. I'm reasonably sure this is true. Any reuse of this install will cause long term problems due to the epoch versioning.

Yes, you are correct. The whole builder VM is scraped down, and a new one is created. 

Apart from that, this looks good to me. I will ask other LP folks to take a look. 

-- 
https://code.launchpad.net/~jchittum/launchpad-buildd/+git/launchpad-buildd/+merge/482782
Your team Launchpad code reviewers is requested to review the proposed merge of ~jchittum/launchpad-buildd:oci-docker-ppa-pin into launchpad-buildd:master.