launchpad-reviewers team mailing list archive

[İlker Emre Koç <mp+482827@xxxxxxxxxxxxxxxxxx>]

Please review the creation of the tempfiles in "createResetableStream" method. We create them, but should we destroy them? In the current state, if we run the tests we get 3 or 4 "ResourceWarning"s since the temp-file doesn't get closed. In other words, we are at the mercy of garbace collection. This may be normal though as other parts of Launchpad or Zope may also rely on garbage collection.

But I am not sure. I tried closing the unused buffer/temp-file as well but kept getting the same warnings. Is there anything I can or should do?
-- 
https://code.launchpad.net/~ilkeremrekoc/launchpad/+git/launchpad/+merge/482827
Your team Launchpad code reviewers is requested to review the proposed merge of ~ilkeremrekoc/launchpad:upgrade-multipart into launchpad:master.