launchpad-reviewers team mailing list archive

[Guruprasad <mp+483364@xxxxxxxxxxxxxxxxxx>]

Guruprasad has proposed merging ~lgp171188/launchpad:disable-flaky-urlfetch-timeout-test into launchpad:master.

Commit message:
Disable a known, flaky unit test

This test is causing too many buildbot run failures, blocking deployments

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~lgp171188/launchpad/+git/launchpad/+merge/483364
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~lgp171188/launchpad:disable-flaky-urlfetch-timeout-test into launchpad:master.

diff --git a/lib/lp/services/tests/test_timeout.py b/lib/lp/services/tests/test_timeout.py
index 0c68401..fd52bb0 100644
--- a/lib/lp/services/tests/test_timeout.py
+++ b/lib/lp/services/tests/test_timeout.py
@@ -6,6 +6,7 @@
 
 import socket
 import threading
+import unittest
 import xmlrpc.client
 import xmlrpc.server
 from textwrap import dedent
@@ -282,6 +283,9 @@ class TestTimeout(TestCase):
         e = self.assertRaises(ConnectionError, urlfetch, http_server_url)
         self.assertIn("Connection refused", str(e))
 
+    @unittest.skip(
+        "Disabling due to flakiness. Causes repeated buildbot failures."
+    )
     def test_urlfetch_timeout_after_listen(self):
         """After the listen() is called, connections will hang until accept()
         is called, so a TimeoutError will be raised.