launchpad-reviewers team mailing list archive

[Alvaro Crespo Serrano <mp+483410@xxxxxxxxxxxxxxxxxx>]

The proposal to merge ~alvarocs/launchpad-buildd:charms-platform-name into launchpad-buildd:master has been updated.

Description changed to:

This adds support for a new "recipe_platform_name" parameter in charm builds, used to identify the platform for which a charm is being built. This is part of Launchpad's integration with craft-platforms and allows the builder to set the 'CRAFT_PLATFORM' environment variable accordingly.

Changes include:
-lpbuildd/charm.py: accepting 'recipe_platform_name' parameter in 'CharmBuildManager' via extra args.
-lpbuildd/tests/test_charm.py - tests to ensure parameter is passed through correctly.
-lpbuildd/target/build_charm.py: forwarding the parameter to the build script via '--recipe-platform-name' and injecting 'CRAFT_PLATFORM' into the environment in BuildCharm.build().
-lpbuildd/target/tests/test_build_charm.py - test build with the '--recipe_platform_name' argument and the build is able to set the 'CRAFT_PLATFORM' env var.


For more details, see:
https://code.launchpad.net/~alvarocs/launchpad-buildd/+git/launchpad-buildd/+merge/483410
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~alvarocs/launchpad-buildd:charms-platform-name into launchpad-buildd:master.