launchpad-reviewers team mailing list archive

[Alvaro Crespo Serrano <mp+483337@xxxxxxxxxxxxxxxxxx>]

The proposal to merge ~alvarocs/launchpad:charms-craft-platforms into launchpad:master has been updated.

Description changed to:

Changes include:

Charms base configuration and build planning
- lp/charms/adapters/buildarch.py - replace custom unified base with craft-platforms API, reformat code with helper functions, add comments.
- lp/charms/adapters/tests/test_buildarch.py - improve and extend existing test coverage, add multi-base platforms tests handled by craft-platforms.

Charm recipe model
- lp/charms/interfaces/charmrecipebuild.py, model/charmrecipebuild.py - store craft_platform on CharmRecipeBuild storm object.
- lp/charms/model/charmrecipe.py - pass platform name through 'requestBuild' and 'requestBuildsFromJob'.
- lp/charms/tests/test_charmrecipe.py - add tests to verify 'craft_platform' is passed through.

Build behaviour
- lp/charms/model/charmrecipebuildbehaviour.py - pass 'craft_platform' as extra argument to the builder.
- lp/charms/tests/test_charmrecipebuildbehaviour.py - test coverage for 'craft_platform' argument.
- lp/buildmaster/interfaces/buildfarmjobbehaviour.py - extend BuildArgs interface class to include the new 'craft_platform' field.

Testing
- lp/testing/factory.py - extend factory methods to support setting the new arg

launchpad-buildd MP: https://code.launchpad.net/~alvarocs/launchpad-buildd/+git/launchpad-buildd/+merge/483410
craft-platforms repo https://github.com/canonical/craft-platforms/tree

For more details, see:
https://code.launchpad.net/~alvarocs/launchpad/+git/launchpad/+merge/483337
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~alvarocs/launchpad:charms-craft-platforms into launchpad:master.