launchpad-reviewers team mailing list archive
-
launchpad-reviewers team
-
Mailing list archive
-
Message #32350
Re: [Merge] ~enriqueesanchz/launchpad:cve-cvss-fix into launchpad:master
It seems this commit does a couple of things, which is even indicated by the commit title containing a "and".
Later on, when looking at commits, it makes it harder to reason about changes.
We should try to have separate commits for separate things.
This also makes reviewing easier.
--
https://code.launchpad.net/~enriqueesanchz/launchpad/+git/launchpad/+merge/483925
Your team Launchpad code reviewers is requested to review the proposed merge of ~enriqueesanchz/launchpad:cve-cvss-fix into launchpad:master.
Follow ups
References