launchpad-reviewers team mailing list archive

[Enrique Sánchez <mp+484245@xxxxxxxxxxxxxxxxxx>]

Enrique Sánchez has proposed merging ~enriqueesanchz/launchpad:cve-missing-files into launchpad:master.

Commit message:
Add test_cveimport with bigger number dirs
    
Test that matches cve dirs with name "[0-9]*xxx"

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~enriqueesanchz/launchpad/+git/launchpad/+merge/484245
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~enriqueesanchz/launchpad:cve-missing-files into launchpad:master.

diff --git a/lib/lp/bugs/scripts/tests/test_cveimport.py b/lib/lp/bugs/scripts/tests/test_cveimport.py
index 50f376b..745b863 100644
--- a/lib/lp/bugs/scripts/tests/test_cveimport.py
+++ b/lib/lp/bugs/scripts/tests/test_cveimport.py
@@ -142,6 +142,34 @@ class TestCVEUpdater(TestCase):
         self.assertIsNotNone(cve)
         self.assertEqual("Test description", cve.description)
 
+    def test_process_json_directory_with_bigger_group_name(self):
+        """Test processing a directory of CVE JSON files."""
+        # Create test directory structure
+        base_dir = Path(self.temp_dir) / "cves"
+        year_dir = base_dir / "2025"
+        # CVEs can be > 9xxx
+        group_dir = year_dir / "9000xxx"
+        group_dir.mkdir(parents=True)
+
+        # Create a test CVE file
+        cve_file = group_dir / "CVE-2024-9000001.json"
+        cve_data = self.create_test_json_cve(cve_id="2024-9000001")
+        cve_file.write_text(json.dumps(cve_data))
+
+        # Process the directory using the script infrastructure
+        updater = self.make_updater([str(base_dir)])
+        processed, errors = updater.process_json_directory(str(base_dir))
+
+        # Verify results
+        self.assertEqual(1, processed)
+        self.assertEqual(0, errors)
+
+        # Verify CVE was created
+        cveset = getUtility(ICveSet)
+        cve = cveset["2024-9000001"]
+        self.assertIsNotNone(cve)
+        self.assertEqual("Test description", cve.description)
+
     def test_process_delta_directory(self):
         """Test processing a directory of delta CVE files."""
         # Create test delta directory