launchpad-reviewers team mailing list archive

[Alvaro Crespo Serrano <mp+485084@xxxxxxxxxxxxxxxxxx>]

The proposal to merge ~alvarocs/launchpad:use-craft-platforms-for-snap into launchpad:master has been updated.

Description changed to:

Fixes short notation format bugs: https://bugs.launchpad.net/launchpad/+bug/2077005 & https://forum.snapcraft.io/t/call-for-testing-snapcraft-8-7-0/45762

Changes include:

Build planning
- lp/snappy/adapters/buildarch.py: reformat code to use craft-platforms API for 'platforms' recipe format.
- lp/snappy/adapters/tests/test_buildarch.py: update existing tests with platform name assertion, extend test suite.

Snap model
- lp/snappy/interfaces/snapbuild.py, model/snapbuild.py - store craft_platform on SnapBuild storm object.
- lp/snappy/model/snap.py - pass platform name through 'requestBuild' and 'requestBuildsFromJob'.
- lp/snappy/tests/test_snap.py - add tests to verify 'craft_platform' is passed through.

Build behaviour
- lp/snappy/model/snapbuildbehaviour.py - pass 'craft_platform' as extra argument to the builder.
- lp/snappy/tests/test_snapbuildbehaviour.py - test coverage for 'craft_platform' argument.

For more details, see:
https://code.launchpad.net/~alvarocs/launchpad/+git/launchpad/+merge/485084
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~alvarocs/launchpad:use-craft-platforms-for-snap into launchpad:master.