launchpad-reviewers team mailing list archive

[Quentin Debhi <mp+485412@xxxxxxxxxxxxxxxxxx>]

Quentin Debhi has proposed merging ~ruinedyourlife/launchpad:native-publisher-roles into launchpad:master.

Commit message:
Use existing craft-build-job & uploader roles

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~ruinedyourlife/launchpad/+git/launchpad/+merge/485412
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~ruinedyourlife/launchpad:native-publisher-roles into launchpad:master.

diff --git a/charm/launchpad-native-publisher/layer.yaml b/charm/launchpad-native-publisher/layer.yaml
index a295ae8..f67e6d1 100644
--- a/charm/launchpad-native-publisher/layer.yaml
+++ b/charm/launchpad-native-publisher/layer.yaml
@@ -7,5 +7,5 @@ options:
       db:
         name: launchpad_dev
         roles:
-          - craft-publish-job
-          # TODO: might need uploading role? need to check when testing
+          - craft-build-job
+          - uploader
diff --git a/lib/lp/services/config/schema-lazr.conf b/lib/lp/services/config/schema-lazr.conf
index e8b4d44..2a04ef4 100644
--- a/lib/lp/services/config/schema-lazr.conf
+++ b/lib/lp/services/config/schema-lazr.conf
@@ -2044,7 +2044,7 @@ crontab_group: MAIN
 
 [ICraftPublishingJobSource]
 module: lp.crafts.interfaces.craftrecipejob
-dbuser: craft-publish-job
+dbuser: craft-build-job
 crontab_group: MAIN
 
 [ICIBuildUploadJobSource]