← Back to team overview

launchpad-reviewers team mailing list archive

Re: [Merge] ~alvarocs/launchpad:test-prod into ~alvarocs/launchpad:master

 

main comment with several inline comments

Diff comments:

> diff --git a/lib/lp/code/model/gitrepository.py b/lib/lp/code/model/gitrepository.py
> index 483f986..924ebaa 100644
> --- a/lib/lp/code/model/gitrepository.py
> +++ b/lib/lp/code/model/gitrepository.py
> @@ -421,10 +421,14 @@ class GitRepository(
>              "ci:build:0.1",
>              "git:push:0.1",
>              "merge-proposal:0.1",
> +            # comment 1

inline comment number 1

>              "merge-proposal:0.1::create",
> +            # comment 2

inline comment number 2

>              "merge-proposal:0.1::push",
> +            # comment 3
>              "merge-proposal:0.1::review",
>              "merge-proposal:0.1::edit",
> +            # comment 4
>              "merge-proposal:0.1::status-change",
>              "merge-proposal:0.1::delete",
>          ]


-- 
https://code.launchpad.net/~alvarocs/launchpad/+git/launchpad/+merge/485732
Your team Launchpad code reviewers is requested to review the proposed merge of ~alvarocs/launchpad:test-prod into ~alvarocs/launchpad:master.



References