launchpad-reviewers team mailing list archive

[Guruprasad <mp+486004@xxxxxxxxxxxxxxxxxx>]

Diff comments:

> diff --git a/database/schema/patch-2211-40-0.sql b/database/schema/patch-2211-40-0.sql
> new file mode 100644
> index 0000000..3e7d5cc
> --- /dev/null
> +++ b/database/schema/patch-2211-40-0.sql
> @@ -0,0 +1,12 @@
> +-- Copyright 2025 Canonical Ltd.  This software is licensed under the
> +-- GNU Affero General Public License version 3 (see the file LICENSE).
> +
> +SET client_min_messages=ERROR;
> +
> +ALTER TABLE BranchMergeProposal
> +    ADD COLUMN merge_type integer DEFAULT 0 NOT NULL;

Can you add a comment explaining what the above magic value, 0, corresponds to and if there are any other existing values with a corresponding meaning, list them too?

Also, does 0 correspond to the state where a merge proposal was not merged using the new Launchpad merge API? If no, how do we represent those merge proposals?

> +
> +COMMENT ON COLUMN BranchMergeProposal.merge_type
> +    IS 'The type of merge used in proposal merged through launchpad API';
> +
> +INSERT INTO LaunchpadDatabaseRevision VALUES (2211, 40, 0);


-- 
https://code.launchpad.net/~ines-almeida/launchpad/+git/launchpad/+merge/486004
Your team Launchpad code reviewers is requested to review the proposed merge of ~ines-almeida/launchpad:merge-button/add-merge-type-db into launchpad:db-devel.