launchpad-reviewers team mailing list archive

[Guruprasad <mp+486199@xxxxxxxxxxxxxxxxxx>]

Review: Approve

LGTM 👍

Diff comments:

> diff --git a/vbuilder/bundle.yaml b/vbuilder/bundle.yaml
> index 19eb047..0b459af 100644
> --- a/vbuilder/bundle.yaml
> +++ b/vbuilder/bundle.yaml
> @@ -228,8 +229,13 @@ applications:
>      options:
>        content_id_template: "{{ content_id_template }}"
>        custom_properties: "hw_emulation_architecture=riscv64 hw_machine_type=virt hw_video_model=virtio kernel_id={{ kernel_id_bos03_riscv64 }}"
> +{%- if stage_name in ("qastaging") %}
> +      mirror_list: |-
> +        [{url: "http://cloud-images.ubuntu.com/daily/";, name_prefix: "ubuntu:released", path: "streams/v1/index.sjson", max: 3, item_filters: ["release~({{ gss_series_only_noble }})", "arch~(riscv64)", "ftype~(disk1.img|disk.img)"]}]

I recommend putting in noble directly without using one more template variable. Also I don't see a reason for gating this just to qastaging. It should be fine to enable it for production too.

> +{%- else %}
>        mirror_list: |-
>          [{url: "http://cloud-images.ubuntu.com/daily/";, name_prefix: "ubuntu:released", path: "streams/v1/index.sjson", max: 3, item_filters: ["release~({{ gss_series_with_noble }})", "arch~(riscv64)", "ftype~(disk1.img|disk.img)"]}]
> +{%- endif %}
>        name_prefix: "{{ name_prefix }}/"
>        openstack-auth-url: "https://keystone.ps6.canonical.com:5000/v3";
>        openstack-identity-api-version: "3"


-- 
https://code.launchpad.net/~tushar5526/launchpad-mojo-specs/+git/private/+merge/486199
Your team Launchpad code reviewers is subscribed to branch ~launchpad/launchpad-mojo-specs/+git/private:vbuilder.