launchpad-reviewers team mailing list archive

[Alvaro Crespo Serrano <mp+486564@xxxxxxxxxxxxxxxxxx>]

Alvaro Crespo Serrano has proposed merging ~alvarocs/launchpad:charm-end-fetch-service into launchpad:master.

Commit message:
Close fetch service session for charm builds

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~alvarocs/launchpad/+git/launchpad/+merge/486564

add '_saveBuildSpecificFiles' method to charm recipe build behaviour to close the fetch service session and be able to retrieve the metadata file.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~alvarocs/launchpad:charm-end-fetch-service into launchpad:master.

diff --git a/lib/lp/charms/model/charmrecipebuildbehaviour.py b/lib/lp/charms/model/charmrecipebuildbehaviour.py
index 20321a0..f63e327 100644
--- a/lib/lp/charms/model/charmrecipebuildbehaviour.py
+++ b/lib/lp/charms/model/charmrecipebuildbehaviour.py
@@ -131,3 +131,7 @@ class CharmRecipeBuildBehaviour(BuilderProxyMixin, BuildFarmJobBehaviourBase):
         # that check does not make sense.  We do, however, refuse to build
         # for obsolete series.
         assert self.build.distro_series.status != SeriesStatus.OBSOLETE
+
+    @defer.inlineCallbacks
+    def _saveBuildSpecificFiles(self, upload_path):
+        yield self.endProxySession(upload_path)