launchpad-reviewers team mailing list archive

[Guruprasad <mp+486923@xxxxxxxxxxxxxxxxxx>]

Diff comments:

> diff --git a/lib/lp/charms/model/charmrecipejob.py b/lib/lp/charms/model/charmrecipejob.py
> index 56efa07..bf06390 100644
> --- a/lib/lp/charms/model/charmrecipejob.py
> +++ b/lib/lp/charms/model/charmrecipejob.py
> @@ -173,6 +173,15 @@ class CharmRecipeRequestBuildsJob(CharmRecipeJobDerived):
>      @classmethod
>      def create(cls, recipe, requester, channels=None, architectures=None):
>          """See `ICharmRecipeRequestBuildsJobSource`."""
> +        # architectures can be a iterable of strings or ProcessorsAdd
> +        # commentMore actions in the latter case, we need to convert
> +        # them to strings

`architectures can be **an** iterable of strings`

Also, can you clarify what the above sentence tries to convey? I am unable to understand what ProcessorsAdd commentMore actions refers to.

> +        if architectures and all(
> +            not (isinstance(arch, str)) for arch in architectures
> +        ):

Afaik, the brackets around the `isinstance()` call can be dropped.

> +            architectures = [
> +                architecture.name for architecture in architectures
> +            ]
>          metadata = {
>              "requester": requester.id,
>              "channels": channels,


-- 
https://code.launchpad.net/~alvarocs/launchpad/+git/launchpad/+merge/486923
Your team Launchpad code reviewers is requested to review the proposed merge of ~alvarocs/launchpad:request-archs-charms into launchpad:master.