launchpad-reviewers team mailing list archive

[Guruprasad <mp+487496@xxxxxxxxxxxxxxxxxx>]

Guruprasad has proposed merging ~lgp171188/launchpad:rocketfuel-setup-fixes into launchpad:master.

Commit message:
Inline the dev environment system package dependencies

This fixes a bug caused by the previous quoting.


Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~lgp171188/launchpad/+git/launchpad/+merge/487496
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~lgp171188/launchpad:rocketfuel-setup-fixes into launchpad:master.

diff --git a/utilities/rocketfuel-setup b/utilities/rocketfuel-setup
index bfad496..9793261 100755
--- a/utilities/rocketfuel-setup
+++ b/utilities/rocketfuel-setup
@@ -84,9 +84,8 @@ for hostname in $hostnames; do
   dev_host;
 done
 
-REQUIRED_PACKAGES="launchpad-developer-dependencies apache2 libapache2-mod-wsgi-py3"
 sudo add-apt-repository -u $INSTALL_OPTS ppa:launchpad/ppa
-sudo apt install $INSTALL_OPTS "$REQUIRED_PACKAGES"
+sudo apt install $INSTALL_OPTS launchpad-developer-dependencies apache2 libapache2-mod-wsgi-py3
 
 # Create the document root(s) to avoid Apache warnings
 mkdir -p /var/tmp/bazaar.launchpad.test/static