launchpad-reviewers team mailing list archive

[Quentin Debhi <mp+487668@xxxxxxxxxxxxxxxxxx>]

Diff comments:

> diff --git a/lib/lp/crafts/model/craftrecipebuildjob.py b/lib/lp/crafts/model/craftrecipebuildjob.py
> index f1cbcf5..c799b7f 100644
> --- a/lib/lp/crafts/model/craftrecipebuildjob.py
> +++ b/lib/lp/crafts/model/craftrecipebuildjob.py
> @@ -381,6 +381,12 @@ class CraftPublishingJob(CraftRecipeBuildJobDerived):
>  
>              f.write(config_content)
>  
> +        # Create credentials.toml
> +        with open(os.path.join(cargo_dir, "credentials.toml"), "w") as f:
> +            f.write(

i cannot check directly if the login works or not, as the error is gonna be raised in the cargo command call (which is mocked in our tests).
this is the same argument as the proxy configuration, there is no erroring out on missing a credentials file just like when missing a proxy, because one could use this same exact code in another environment, and trying to publish to crates.io instead of a private repository.

> +                "\n" "[registries.launchpad]\n" f'token = "Bearer {token}"\n'
> +            )
> +
>          # Replace any Cargo.toml files with their .orig versions if they exist,
>          # as the .orig files contain the original content before build
>          # modifications


-- 
https://code.launchpad.net/~ruinedyourlife/launchpad/+git/launchpad/+merge/487668
Your team Launchpad code reviewers is requested to review the proposed merge of ~ruinedyourlife/launchpad:fix-wrong-conflict-removal into launchpad:master.