launchpad-reviewers team mailing list archive

[Alvaro Crespo Serrano <mp+487377@xxxxxxxxxxxxxxxxxx>]

The proposal to merge ~alvarocs/lp-signing/+git/lp-signing-1:upgrade-noble into lp-signing:master has been updated.

Description changed to:

Changes to upgrade lp-signing so it builds, tests and runs on Noble with Python 3.12. The dependencies repo merge proposal is in: https://code.launchpad.net/~alvarocs/lp-signing/+git/dependencies/+merge/487735

- Updated the base platform to reference noble from bionic.
- Update of requirements and requirements-dev dependencies and its pinned versions to be compatible with Noble Python 3.12.
- Update and run pre-commit to all files
- Update tox with 3.12 and added lint
- Version bump in setup.py to 0.2
- Werkzeug/Flask 2.3 change: Modify '_get_data_for_json' in auth.py to 'get_data' as it has been deprecated in recent 2.3.x versions of Flask/Werkzeug, so now we directly override get_data().
   - For tests where no json was sent (test_no_json) it would call twice get_data so it would error out in the 'Nonce.check()' in the second call. For this, introduced a flag 'boxed_plaintext' to only decrypt the body when it has not been decrypted before.
- Several code fixes for python 3.12 (datetime, flask.g, assertCountEqual)
- Fix dependencies repo link in Makefile to clone it properly while bootstraping.

For more details, see:
https://code.launchpad.net/~alvarocs/lp-signing/+git/lp-signing-1/+merge/487377
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~alvarocs/lp-signing/+git/lp-signing-1:upgrade-noble into lp-signing:master.