launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] ~tushar5526/lp-codeimport:move-to-kombu-from-amqp into ~tushar5526/lp-codeimport:deprecate-bzr

To: Tushar Gupta <tushar.gupta@xxxxxxxxxxxxx>
From: Tushar Gupta <mp+488158@xxxxxxxxxxxxxxxxxx>
Date: Wed, 02 Jul 2025 08:06:56 -0000
In-reply-to: <175144245104.2279841.15036285993093097961.launchpad@scripts-bzrsyncd.lp.internal>
Reply-to: mp+488158@xxxxxxxxxxxxxxxxxx
Sender: noreply@xxxxxxxxxxxxx

It looks like earlier LP used to maintain custom code to create rabbitmq sessions using the low level amqp library. The custom rabbitmq session implementations were only needed by txlongpoll which has been deprecated from LP. 

Keeping LP as point of reference, I added supported for kombu and depreacted amqp from lp-codeimport. 

We will need relevant charm changes as well, but that will come later. 
-- 
https://code.launchpad.net/~tushar5526/lp-codeimport/+git/lp-codeimport/+merge/488158
Your team Launchpad code reviewers is requested to review the proposed merge of ~tushar5526/lp-codeimport:move-to-kombu-from-amqp into ~tushar5526/lp-codeimport:deprecate-bzr.

References

[Merge] ~tushar5526/lp-codeimport:move-to-kombu-from-amqp into ~tushar5526/lp-codeimport:deprecate-bzr
From: Tushar Gupta, 2025-07-02