launchpad-reviewers team mailing list archive

[Quentin Debhi <mp+488533@xxxxxxxxxxxxxxxxxx>]

Quentin Debhi has proposed merging ~ruinedyourlife/launchpad:when-to-hook-native-publisher into launchpad:master.

Commit message:
Update 'when' trigger to 'hook'

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~ruinedyourlife/launchpad/+git/launchpad/+merge/488533
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~ruinedyourlife/launchpad:when-to-hook-native-publisher into launchpad:master.

diff --git a/charm/launchpad-native-publisher/reactive/launchpad-native-publisher.py b/charm/launchpad-native-publisher/reactive/launchpad-native-publisher.py
index cdb7ce8..63f7999 100644
--- a/charm/launchpad-native-publisher/reactive/launchpad-native-publisher.py
+++ b/charm/launchpad-native-publisher/reactive/launchpad-native-publisher.py
@@ -15,6 +15,7 @@ from charms.launchpad.payload import (
 )
 from charms.reactive import (
     helpers,
+    hook,
     remove_state,
     set_state,
     when,
@@ -160,7 +161,7 @@ def deconfigure():
     remove_state("service.configured")
 
 
-@when("install")
+@hook("install")
 def install_packages():
     """Install Rust, Cargo, Java and Maven dependencies."""
     hookenv.status_set("maintenance", "Installing packages")