launchpad-reviewers team mailing list archive
-
launchpad-reviewers team
-
Mailing list archive
-
Message #32707
Re: [Merge] ~ruinedyourlife/launchpad:native-pub-ensure-deps into launchpad:master
removed install hook as all our other charms do not use one
the setup seem to be happening in this common pattern:
```py
@when(
"launchpad.db.configured",
)
@when_not("service.configured")
def configure():
# execute config-changed hook related work
# which gets executed after a install too anyways
```
--
https://code.launchpad.net/~ruinedyourlife/launchpad/+git/launchpad/+merge/488593
Your team Launchpad code reviewers is requested to review the proposed merge of ~ruinedyourlife/launchpad:native-pub-ensure-deps into launchpad:master.
References