launchpad-reviewers team mailing list archive

[Ines Almeida <mp+488673@xxxxxxxxxxxxxxxxxx>]

Diff comments:

> diff --git a/lib/lp/bugs/browser/bugtask.py b/lib/lp/bugs/browser/bugtask.py
> index 8fcb135..69f7f0c 100644
> --- a/lib/lp/bugs/browser/bugtask.py
> +++ b/lib/lp/bugs/browser/bugtask.py
> @@ -320,7 +321,12 @@ class BugTargetTraversalMixin:
>          # rather than making it look as though this task was "not found",
>          # because it was filtered out by privacy-aware code.
>          for bugtask in bug.bugtasks:
> -            if bugtask.target == context:
> +            if bugtask.target == context or IExternalPackage.providedBy(
> +                bugtask.target
> +            ):
> +                # TODO: set +external urls for ExternalPackages
> +                # actually we select the first ExternalPackage that appears

s/actually/currently/g

> +
>                  # Security proxy this object on the way out.
>                  return getUtility(IBugTaskSet).get(bugtask.id)
>  


-- 
https://code.launchpad.net/~enriqueesanchz/launchpad/+git/launchpad/+merge/488673
Your team Launchpad code reviewers is requested to review the proposed merge of ~enriqueesanchz/launchpad:add-external-package into launchpad:master.