launchpad-reviewers team mailing list archive

[Alvaro Crespo Serrano <mp+488842@xxxxxxxxxxxxxxxxxx>]

Alvaro Crespo Serrano has proposed merging ~alvarocs/lp-signing/+git/lp-signing-1:upgrade-charm into lp-signing:master.

Commit message:
Upgrade charm to be built for Ubuntu Noble 24.04

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~alvarocs/lp-signing/+git/lp-signing-1/+merge/488842

- Updated series from bionic to noble in charmcraft.yaml
- Updated format in charmcraft.yaml from old bases to new base+platforms
- Updated metadata.yaml, removing series tag as it's not used anymore: ":: proof: I: DEPRECATED: series parameter is ignored by charmcraft,use bases in charmcraft.yaml"
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~alvarocs/lp-signing/+git/lp-signing-1:upgrade-charm into lp-signing:master.

diff --git a/charm/lp-signing/charmcraft.yaml b/charm/lp-signing/charmcraft.yaml
index e0454fe..041942d 100644
--- a/charm/lp-signing/charmcraft.yaml
+++ b/charm/lp-signing/charmcraft.yaml
@@ -1,13 +1,8 @@
 type: charm
-bases:
-  - build-on:
-    - name: ubuntu
-      channel: "18.04"
-      architectures: [amd64]
-    run-on:
-    - name: ubuntu
-      channel: "18.04"
-      architectures: [amd64]
+
+base: ubuntu@24.04
+platforms:
+  amd64: 
 parts:
   charm-wheels:
     source: https://git.launchpad.net/~ubuntuone-hackers/ols-charm-deps/+git/wheels