launchpad-reviewers team mailing list archive

[Ines Almeida <mp+489197@xxxxxxxxxxxxxxxxxx>]

Ines Almeida has proposed merging ~ines-almeida/turnip:fix-async-merge-notify into turnip:master.

Commit message:
Add auth params to notify Launchpad of push after merge

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~ines-almeida/turnip/+git/turnip/+merge/489197
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~ines-almeida/turnip:fix-async-merge-notify into turnip:master.

diff --git a/turnip/api/store.py b/turnip/api/store.py
index 706d9a0..edbe396 100644
--- a/turnip/api/store.py
+++ b/turnip/api/store.py
@@ -1063,6 +1063,7 @@ def merge_async(
     # Setup xmlrpc to notify Launchpad of a push when merge is successful
     xmlrpc_endpoint = config.get("virtinfo_endpoint")
     xmlrpc_timeout = float(config.get("virtinfo_timeout"))
+    xmlrpc_auth_params = {"user": "+launchpad-services"}
     xmlrpc_proxy = TimeoutServerProxy(
         xmlrpc_endpoint, timeout=xmlrpc_timeout, allow_none=True
     )
@@ -1170,7 +1171,7 @@ def merge_async(
             }
         )
         try:
-            xmlrpc_proxy.notify(repo_name, statistics)
+            xmlrpc_proxy.notify(repo_name, statistics, xmlrpc_auth_params)
             logger.info(f"[{repo_name}] Push notification sent to LP")
         except xmlrpc.Fault:
             logger.error(