launchpad-reviewers team mailing list archive

[Ines Almeida <mp+489773@xxxxxxxxxxxxxxxxxx>]

This is a nice change, just needs a minor update to the id of the element

Diff comments:

> diff --git a/lib/lp/code/templates/bazaar-index.pt b/lib/lp/code/templates/bazaar-index.pt
> index 2a5cee7..28821ea 100644
> --- a/lib/lp/code/templates/bazaar-index.pt
> +++ b/lib/lp/code/templates/bazaar-index.pt
> @@ -38,9 +38,12 @@
>        </script>
>  
>        <p id="application-summary">
> +        <a href="http://bazaar.canonical.com/";>Bazaar</a> will be deprecated
> +        in September 2025.
> +      </p>
> +      <p id="application-summary">

It doesn't make sense to have 2 elements with the same id `application-summary`.
You should either have both in the same element, or use a different id for one of them, though the styling will look different

>          Launchpad can host your project&#8217;s source code
> -        using the <a href="http://bazaar.canonical.com/";>Bazaar</a>
> -        or the <a href="https://git-scm.com/";>Git</a>
> +        using the <a href="https://git-scm.com/";>Git</a>
>          version control system.
>          We also import
>          <tal:XXX condition="nothing">


-- 
https://code.launchpad.net/~enriqueesanchz/launchpad/+git/launchpad/+merge/489773
Your team Launchpad code reviewers is requested to review the proposed merge of ~enriqueesanchz/launchpad:code-bazaar-deprecate-date into launchpad:master.