launchpad-reviewers team mailing list archive

[Guruprasad <mp+490523@xxxxxxxxxxxxxxxxxx>]

Guruprasad has proposed merging ~lgp171188/launchpad:mirror-prober-log-full-url-when-raising-redirect-to-different-file-exception into launchpad:master.

Commit message:
Log the full URLs when raising the RedirectToDifferentFile exception
  
This will allow identifying broken mirrors easily.


Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~lgp171188/launchpad/+git/launchpad/+merge/490523
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~lgp171188/launchpad:mirror-prober-log-full-url-when-raising-redirect-to-different-file-exception into launchpad:master.

diff --git a/lib/lp/registry/scripts/distributionmirror_prober.py b/lib/lp/registry/scripts/distributionmirror_prober.py
index 9dd2cf2..b6a47e7 100644
--- a/lib/lp/registry/scripts/distributionmirror_prober.py
+++ b/lib/lp/registry/scripts/distributionmirror_prober.py
@@ -487,7 +487,7 @@ class RedirectAwareProberFactory(ProberFactory):
             # Server redirected us to a file which doesn't seem to be what we
             # requested.  It's likely to be a stupid server which redirects
             # instead of 404ing (https://launchpad.net/bugs/204460).
-            self.failed(Failure(RedirectToDifferentFile(orig_path, new_path)))
+            self.failed(Failure(RedirectToDifferentFile(self.url, url)))
             return
 
         try: