launchpad-reviewers team mailing list archive

[Ines Almeida <mp+490568@xxxxxxxxxxxxxxxxxx>]

Ines Almeida has proposed merging ~ines-almeida/launchpad:fix-fetch-service-policy-required into launchpad:master.

Commit message:
Revert change that made fetch_service_policy required
    
This was added in a previous commit and led to remove build issues.
A better solution will require looking into why the default value of "strict" isn't set.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~ines-almeida/launchpad/+git/launchpad/+merge/490568

Ideally, this would come with a test, but it is just a revert from https://code.launchpad.net/~vaishnavi-asawale/launchpad/+git/launchpad-1/+merge/490259 and it's 1AM. Instead I ran all tests that contain the word "snap"

-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~ines-almeida/launchpad:fix-fetch-service-policy-required into launchpad:master.

diff --git a/lib/lp/snappy/interfaces/snap.py b/lib/lp/snappy/interfaces/snap.py
index 9672734..98b11bb 100644
--- a/lib/lp/snappy/interfaces/snap.py
+++ b/lib/lp/snappy/interfaces/snap.py
@@ -1156,7 +1156,7 @@ class ISnapEditableAttributes(IHasOwner):
         Choice(
             title=_("Fetch service policy"),
             vocabulary=FetchServicePolicy,
-            required=True,
+            required=False,
             readonly=False,
             default=FetchServicePolicy.STRICT,
             description=_(