launchpad-reviewers team mailing list archive

[Alvaro Crespo Serrano <mp+490628@xxxxxxxxxxxxxxxxxx>]

The proposal to merge ~alvarocs/launchpad:fix-charm-build-metadataurl into launchpad:master has been updated.

Description changed to:

Changes to expose 'build_metadata_url' property for 'CharmRecipeBuild' objects via the API, allowing users to retrieve the build metadata file if generated.

The previous implementation caused 'test_builds_query_count' to fail because 'getFileUrls()' executed a db query for each build, exceeding the expected total queries in the test. This implementation, following the pattern used for snaps, preloads all related 'CharmFile' objects in 'preloadBuildsData' so that 'build_metadata_url' can be obtained from this already fetched data without extra database queries for each build.

For more details, see:
https://code.launchpad.net/~alvarocs/launchpad/+git/launchpad/+merge/490628
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~alvarocs/launchpad:fix-charm-build-metadataurl into launchpad:master.