launchpad-reviewers team mailing list archive

[Jürgen Gmach <mp+492040@xxxxxxxxxxxxxxxxxx>]

Diff comments:

> diff --git a/lib/lp/answers/interfaces/questioncollection.py b/lib/lp/answers/interfaces/questioncollection.py
> index e6d370b..83e778e 100644
> --- a/lib/lp/answers/interfaces/questioncollection.py
> +++ b/lib/lp/answers/interfaces/questioncollection.py
> @@ -48,6 +48,20 @@ class IQuestionCollection(Interface):
>              value_type=ReferenceChoice(vocabulary="Language"),
>          ),
>          sort=Choice(title=_("Sort"), required=False, vocabulary=QuestionSort),
> +        created_before=Datetime(
> +            title=_(
> +                "Search for questions that were created"
> +                "before the given date."

Won't this be concatenated without a space between "created" and "before"? I think you need to add a space after "created".

This means, we have no test for this, otherwise this would have been uncovered.

Unfortunately, when looking at other titles, it seems we usually do not test them.

If you see an easy way to add a test, please do so, if not, I am happy to proceed as is.

> +            ),
> +            required=False,
> +        ),
> +        created_since=Datetime(
> +            title=_(
> +                "Search for questions that were created"
> +                "since the given date."
> +            ),
> +            required=False,
> +        ),
>      )
>      @operation_returns_collection_of(Interface)  # IQuestion.
>      @export_read_operation()


-- 
https://code.launchpad.net/~finnrg/launchpad/+git/launchpad/+merge/492040
Your team Launchpad code reviewers is requested to review the proposed merge of ~finnrg/launchpad:feat/LP-2652-searchQuestion-datecreated into launchpad:master.