launchpad-reviewers team mailing list archive

[Yuliy Schwartzburg <mp+492120@xxxxxxxxxxxxxxxxxx>]

Comment on one line that I think is still out of place.

Diff comments:

> diff --git a/lpbuildd/oci.py b/lpbuildd/oci.py
> index 5ce2cd8..bbf80b5 100644
> --- a/lpbuildd/oci.py
> +++ b/lpbuildd/oci.py
> @@ -174,6 +175,7 @@ class OCIBuildManager(BuildManagerProxyMixin, DebianBuildManager):
>                      if gzip_layer:
>                          # Close the old directory if we have one
>                          gzip_layer.close()
> +                    continue

Why is there a continue here? If we have this, the other code paths with `current_dir` in them will never be called.

>                  if file.issym():
>                      # symlinks can't be extracted or derefenced from a stream
>                      # as you can't seek backwards.


-- 
https://code.launchpad.net/~artemstreltsov/launchpad-buildd/+git/launchpad-buildd/+merge/492120
Your team Launchpad code reviewers is requested to review the proposed merge of ~artemstreltsov/launchpad-buildd:add_docker26.x_support into launchpad-buildd:master.