launchpad-reviewers team mailing list archive
-
launchpad-reviewers team
-
Mailing list archive
-
Message #32959
Re: [Merge] ~artemstreltsov/launchpad-buildd:add_docker26.x_support into launchpad-buildd:master
> > Comment on one line that I think is still out of place.
>
> I can remove the "continue", but we will hit it anyway in the "elif
> current_dir and file.name.startswith(current_dir)" block
Yes, but otherwise it doesn't even go into those code paths. If we have the continue here, then we should delete those other lines it will never get to (and we don't even need the `current_dir` variable right?
--
https://code.launchpad.net/~artemstreltsov/launchpad-buildd/+git/launchpad-buildd/+merge/492120
Your team Launchpad code reviewers is requested to review the proposed merge of ~artemstreltsov/launchpad-buildd:add_docker26.x_support into launchpad-buildd:master.
References