launchpad-reviewers team mailing list archive

[Artem Streltsov <mp+492614@xxxxxxxxxxxxxxxxxx>]

Artem Streltsov has proposed merging ~artemstreltsov/launchpad-buildd:remove_snap_install_hello into launchpad-buildd:master.

Commit message:
Remove "snap install hello"

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~artemstreltsov/launchpad-buildd/+git/launchpad-buildd/+merge/492614
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~artemstreltsov/launchpad-buildd:remove_snap_install_hello into launchpad-buildd:master.

diff --git a/lpbuildd/target/build_livefs.py b/lpbuildd/target/build_livefs.py
index f0a788e..775d4ba 100644
--- a/lpbuildd/target/build_livefs.py
+++ b/lpbuildd/target/build_livefs.py
@@ -3,7 +3,6 @@
 
 import logging
 import os
-import subprocess
 from collections import OrderedDict
 
 from lpbuildd.target.operation import Operation
@@ -139,28 +138,6 @@ class BuildLiveFS(SnapStoreOperationMixin, Operation):
                 ]
             )
 
-        # XXX 2025-01-27 tushar5526: This is a temporary fix to work around
-        # https://bugs.launchpad.net/snapd/+bug/1731519.
-        # Explicitly install a "hello" snap in livefs builds
-        # to workaround the snapd bug where installing a snap
-        # on the first attempt fails due to udev issues. This
-        # fix should be REMOVED after the new release of snapd
-        # in early march.
-        try:
-            self.backend.run(
-                [
-                    "snap",
-                    "install",
-                    "hello",
-                ]
-            )
-        except subprocess.CalledProcessError as e:
-            logger.info(
-                'Unable to install the "hello" snap with error: %s'
-                " Ignoring the failure and proceeding with the next"
-                " steps!" % e
-            )
-
     def build(self):
         if self.args.locale is not None:
             self.run_build_command(