launchpad-reviewers team mailing list archive

[Ines Almeida <mp+493451@xxxxxxxxxxxxxxxxxx>]

Looks good, just a minor comment to address

Diff comments:

> diff --git a/lib/lp/bugs/interfaces/cve.py b/lib/lp/bugs/interfaces/cve.py
> index 4efd60c..7f50341 100644
> --- a/lib/lp/bugs/interfaces/cve.py
> +++ b/lib/lp/bugs/interfaces/cve.py
> @@ -180,6 +180,18 @@ class ICve(Interface):
>          as_of="devel",
>      )
>  
> +    metadata = exported(
> +        Dict(
> +            title=_("metadata"),
> +            description=_("CVE metadata."),
> +            key_type=Text(),
> +            value_type=Text(),
> +            required=False,
> +            readonly=False,

IMO we should make it readonly like the CVSS etc since this is data that we fetch from MITRE that shouldn't differ from it

> +        ),
> +        as_of="devel",
> +    )
> +
>      def createReference(source, content, url=None):
>          """Create a new CveReference for this CVE."""
>  


-- 
https://code.launchpad.net/~enriqueesanchz/launchpad/+git/launchpad/+merge/493451
Your team Launchpad code reviewers is requested to review the proposed merge of ~enriqueesanchz/launchpad:add-metadata-cve-model into launchpad:master.