launchpad-reviewers team mailing list archive

[Vaishnavi Asawale <mp+494933@xxxxxxxxxxxxxxxxxx>]

Vaishnavi Asawale has proposed merging ~vaishnavi-asawale/launchpad:add-build-status-types into launchpad:master.

Commit message:
Add build statuses to trigger binary build webhooks

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~vaishnavi-asawale/launchpad/+git/launchpad/+merge/494933
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~vaishnavi-asawale/launchpad:add-build-status-types into launchpad:master.

diff --git a/lib/lp/services/webhooks/interfaces.py b/lib/lp/services/webhooks/interfaces.py
index f89aaef..26e1fa7 100644
--- a/lib/lp/services/webhooks/interfaces.py
+++ b/lib/lp/services/webhooks/interfaces.py
@@ -77,6 +77,13 @@ WEBHOOK_EVENT_TYPES = {
     "archive:binary-build:0.1": "Binary build",
     "archive:binary-build:0.1::fullybuilt": "Binary build fully built",
     "archive:binary-build:0.1::failedtobuild": "Binary build failed to build",
+    "archive:binary-build:0.1::chrootwait": "Binary build failed due"
+    "to chroot problem",
+    "archive:binary-build:0.1::cancelled": "Binary build cancelled",
+    "archive:binary-build:0.1::failedtoupload": "Binary build failed"
+    "to upload",
+    "archive:binary-build:0.1::superseded": "Binary build for"
+    "superseded source",
 }
 
 
diff --git a/lib/lp/soyuz/model/archive.py b/lib/lp/soyuz/model/archive.py
index 979b89e..e5d8392 100644
--- a/lib/lp/soyuz/model/archive.py
+++ b/lib/lp/soyuz/model/archive.py
@@ -240,6 +240,10 @@ class Archive(StormBase, WebhookTargetMixin):
             "archive:binary-build:0.1",
             "archive:binary-build:0.1::fullybuilt",
             "archive:binary-build:0.1::failedtobuild",
+            "archive:binary-build:0.1::chrootwait",
+            "archive:binary-build:0.1::cancelled",
+            "archive:binary-build:0.1::failedtoupload",
+            "archive:binary-build:0.1::superseded",
         ]
 
     def _validate_archive_name(self, attr, value):
diff --git a/lib/lp/soyuz/subscribers/archive.py b/lib/lp/soyuz/subscribers/archive.py
index 87d26ad..f8eb643 100644
--- a/lib/lp/soyuz/subscribers/archive.py
+++ b/lib/lp/soyuz/subscribers/archive.py
@@ -89,6 +89,10 @@ def build_status_change_webhook(build, event):
         and (
             build.status == BuildStatus.FULLYBUILT
             or build.status == BuildStatus.FAILEDTOBUILD
+            or build.status == BuildStatus.CHROOTWAIT
+            or build.status == BuildStatus.CANCELLED
+            or build.status == BuildStatus.FAILEDTOUPLOAD
+            or build.status == BuildStatus.SUPERSEDED
         )
     ):
         _trigger_build_status_change_webhook(