launchpad-reviewers team mailing list archive

[Ines Almeida <mp+494967@xxxxxxxxxxxxxxxxxx>]

Diff comments:

> diff --git a/lib/lp/soyuz/subscribers/archive.py b/lib/lp/soyuz/subscribers/archive.py
> index f8eb643..5eaa2d0 100644
> --- a/lib/lp/soyuz/subscribers/archive.py
> +++ b/lib/lp/soyuz/subscribers/archive.py
> @@ -46,8 +46,11 @@ def _trigger_build_status_change_webhook(build, event_type):
>              ),
>          }
>  
> -        if getattr(build, "log", None):
> -            payload["buildlog"] = build.log
> +        payload["buildlog"] = (

This should work and be nicer:
```
payload["buildlog"] = build.log_url
```

> +            canonical_url(build.log, force_local_path=True)
> +            if getattr(build, "log", None)
> +            else None
> +        )
>  
>          getUtility(IWebhookSet).trigger(build.archive, event_type, payload)
>  


-- 
https://code.launchpad.net/~vaishnavi-asawale/launchpad/+git/launchpad/+merge/494967
Your team Launchpad code reviewers is requested to review the proposed merge of ~vaishnavi-asawale/launchpad:fix-binary-build-webhooks into launchpad:master.