launchpad-reviewers team mailing list archive

[Guruprasad <mp+495002@xxxxxxxxxxxxxxxxxx>]

Guruprasad has proposed merging ~lgp171188/launchpad-buildd:fix-more-unit-test-failures-sudo-apparmor-restart into launchpad-buildd:master.

Commit message:
Fix more unit tests failing due to the apparmor restart

Mock 'sudo' in the unit tests failing during the build


Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~lgp171188/launchpad-buildd/+git/launchpad-buildd/+merge/495002
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~lgp171188/launchpad-buildd:fix-more-unit-test-failures-sudo-apparmor-restart into launchpad-buildd:master.

diff --git a/lpbuildd/target/tests/test_run_ci.py b/lpbuildd/target/tests/test_run_ci.py
index 0f4f34e..79197b1 100644
--- a/lpbuildd/target/tests/test_run_ci.py
+++ b/lpbuildd/target/tests/test_run_ci.py
@@ -40,6 +40,9 @@ class FakeRevisionID(FakeMethod):
 
 class TestRunCIPrepare(TestCase):
     def test_install_git(self):
+        processes_fixture = self.useFixture(FakeProcesses())
+        processes_fixture.add(lambda _: {}, name="sudo")
+
         args = [
             "run-ci-prepare",
             "--backend=fake",
@@ -116,6 +119,9 @@ class TestRunCIPrepare(TestCase):
         )
 
     def test_install_proxy(self):
+        processes_fixture = self.useFixture(FakeProcesses())
+        processes_fixture.add(lambda _: {}, name="sudo")
+
         args = [
             "run-ci-prepare",
             "--backend=fake",
@@ -155,6 +161,9 @@ class TestRunCIPrepare(TestCase):
         )
 
     def test_install_channels(self):
+        processes_fixture = self.useFixture(FakeProcesses())
+        processes_fixture.add(lambda _: {}, name="sudo")
+
         args = [
             "run-ci-prepare",
             "--backend=fake",
@@ -186,6 +195,9 @@ class TestRunCIPrepare(TestCase):
         )
 
     def test_install_scan_malware(self):
+        processes_fixture = self.useFixture(FakeProcesses())
+        processes_fixture.add(lambda _: {}, name="sudo")
+
         args = [
             "run-ci-prepare",
             "--backend=fake",
@@ -213,6 +225,9 @@ class TestRunCIPrepare(TestCase):
         )
 
     def test_install_scan_malware_proxy(self):
+        processes_fixture = self.useFixture(FakeProcesses())
+        processes_fixture.add(lambda _: {}, name="sudo")
+
         args = [
             "run-ci-prepare",
             "--backend=fake",