← Back to team overview

launchpad-users team mailing list archive

Re: [rfc] allow code reviews with no branch attached


On Tue, May 5, 2009 at 8:56 AM, Martin Pool <mbp@xxxxxxxxxxxxx> wrote:
> This may seem like a kind of strange idea so I thought I'd float it
> here first rather than just opening a bug.  Maybe some variation on
> this is more appropriate.
> I'd like to be able to create a merge proposal object that has no
> branch attached.   Why would I want such a strange thing?  Well, for
> instance because sometimes people attach patches to bugs (or eg put
> them in a pastebin or mail message) that want to be merged back in.
> Obviously I could turn that patch into a proper branch, and will
> eventually, but that can take some time, if eg the patch conflicts.
> What I really want is to just capture the fact that some work needs to
> be done to merge the thing and to kick off the review process.

We do need a way of bringing patches attached to bug trackers into the
wonderful world of DVCS love.

You can already send a merge directive to Launchpad and have it create
the source branch and merge proposal for you.

> I guess in practice this would be hard or infeasible because MPs are
> named by the source (??) branch, so you can't really have one without
> it.

We'd have to create a source branch. This is possible, but as you know
it'll never be exact.

For what it's worth, the Ubuntu community has already requested this:
https://bugs.edge.launchpad.net/launchpad-code/+bug/345577 and I've
filed a nebulous and not particularly useful bug on the overall
problem: https://bugs.edge.launchpad.net/launchpad-code/+bug/297872.