-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Martin Pool wrote: > I hope you won't mind me sending this to the list, because I think it > will help others and they may also have questions. Of course. >> Each branch has an owner, who is the only person or team, aside from >> admins, who can write to the branch. > > It may be worth mentioning this is the name that appears in the branch > url (except for product-namespace branches.) Yes. There are also also exceptions for source packages. > Isn't there still a branch registrant, or did that go? There is, but it's not really relevant to code review. I actually had to go look it up to be sure it was still there. >> By default, this team is requested to review >> any new proposal to merge into this branch. If the review team is not >> set, the branch owner is used as the review team. This setting does not >> cause any additional mail to be sent to members of the review team. > > "By default" meaning unless someone requests the review through the > web ui and chooses a different reviewer? iow the person requesting > the review can choose? Yes, and similarly for merge proposals generated with "bzr lp-submit" or "bzr send". >> Target branch owner and review team >> - ----------------------------------- >> They have edit rights on the merge proposal. Their reviews are not >> shown as "(community)". They can set the overall status of the merge >> proposal (i.e. mark it "approved"/"rejected"/"work in progress"). > > Is that second bit beyond what is implied by "edit rights"? Setting the status of the merge proposal is beyond edit rights. > If so, > maybe you should clarify what the edit rights are? You can - - set the commit message - - delete the merge proposal - - request a review - - resubmit the merge proposal >> Team Reviewers >> - -------------- >> Teams who have been requested to review. Members of these teams may >> claim their team's review. If a member of this team performs a review, >> and the requested review type doesn't conflict with the specified review >> type, the team review request is automatically reassigned to the reviewer. > > .. and "doesn't conflict" means ... the actual review contains a > superset of the words in the requested review? It means that one or both of them is empty, or they are the same. > So thanks, that's cleared it up a lot for me. I'm glad. > I'd like to see it or > something based on this go into launchpad's help. Okay, I'll look into it. Aaron -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAksfOj8ACgkQ0F+nu1YWqI1njACfdxpbsh5z9BJEc7Hl6440D4Wt vjUAniGY3XGyfVOWWU2c2BJjI9ibsAh1 =Kqu8 -----END PGP SIGNATURE-----
This is the launchpad-users mailing list archive — see also the general help for Launchpad.net mailing lists.
(Formatted by MHonArc.)