← Back to team overview

lazr-developers team mailing list archive

Re: [Merge] lp:~gary/lazr.yourpkg/linters into lp:lazr.yourpkg

 

On March 23, 2009, Gary Poster wrote:
> Gary Poster has proposed merging lp:~gary/lazr.yourpkg/linters into
> lp:lazr.yourpkg.
>
> Requested reviews:
>     Francis J. Lacoste (flacoste)
>     LAZR Developers (lazr-developers)
>
> This adds pylint and pyflakes to the lazr.yourpkg template buildout.
>
> Even though our systems have pylint installed, this specifies a different
> version, because, in order to work on other operating systems, we need to
> rely on a package that works with a specific version of pylint.
>
> To try this out, check out the branch, and then, in the branch's top
> directory, run ``python2.4 bootstrap.py`` and ``./bin/buildout.py``.  You
> will then see a lot of complaints because the pylint code is being run and
> python2.4 doesn't like the tests, it seems.  I do not know of a quick way
> to make this prettier or faster.  After ``./bin/buildout`` has run to
> completion, you can then use ``./bin/pylint`` and ``./bin/pyflakes
> [files]``.
>
> This branch also has changes to make pylint give the package a 10/10 (up
> from -6 initially).
>
> I'm interested to see if this is regarded as a valuable addition. :-)

 I find that the installation of pyling and pyflakes are really noisy and 
don't provide much value here. These are stuff that are well packaged in 
Ubuntu and I'm not sure it's worth it to install those locally in each 
zc.buildout. I consider them more of the developer's toolbox kind of utility 
(like a compiler). 

Given that I think we shouldn't include them, but feel free to land the 
de-lint you did :-)

Cheers

-- 
Francis J. Lacoste
francis.lacoste@xxxxxxxxxxxxx

https://code.launchpad.net/~gary/lazr.yourpkg/linters/+merge/4808
Your team LAZR Developers is subscribed to branch lp:lazr.yourpkg.



Follow ups