lightdm-gtk-greeter-team team mailing list archive

[Thaddäus Tintenfisch <thad.fisch@xxxxxxxxx>]

Thaddäus Tintenfisch has proposed merging lp:~thad-fisch/lightdm-gtk-greeter/mlockall into lp:lightdm-gtk-greeter.

Requested reviews:
  LightDM Gtk+ Greeter Development Team (lightdm-gtk-greeter-team)

For more details, see:
https://code.launchpad.net/~thad-fisch/lightdm-gtk-greeter/mlockall/+merge/207792

This is a security related change.

Reference: http://bazaar.launchpad.net/~unity-greeter-team/unity-greeter/trunk/view/head:/src/unity-greeter.vala#L431

-- 
https://code.launchpad.net/~thad-fisch/lightdm-gtk-greeter/mlockall/+merge/207792
Your team LightDM Gtk+ Greeter Development Team is requested to review the proposed merge of lp:~thad-fisch/lightdm-gtk-greeter/mlockall into lp:lightdm-gtk-greeter.

=== modified file 'src/lightdm-gtk-greeter.c'
--- src/lightdm-gtk-greeter.c	2014-02-22 14:52:45 +0000
+++ src/lightdm-gtk-greeter.c	2014-02-22 15:26:35 +0000
@@ -21,6 +21,7 @@
 #include <gtk/gtk.h>
 #include <glib/gi18n.h>
 #include <cairo-xlib.h>
+#include <sys/mman.h>
 #include <sys/wait.h>
 #include <X11/Xlib.h>
 #include <X11/Xatom.h>
@@ -2257,6 +2258,9 @@
     GPid indicator_pid = 0, spi_pid = 0;
     #endif
 
+    /* Prevent memory from being swapped out, as we are dealing with passwords */
+    mlockall (MCL_CURRENT | MCL_FUTURE);
+
     /* Disable global menus */
     g_unsetenv ("UBUNTU_MENUPROXY");