lightdm-gtk-greeter-team team mailing list archive

["Andrew P." <pan.pav.7c5@xxxxxxxxx>]

Andrew P. has proposed merging lp:~lightdm-gtk-greeter-team/lightdm-gtk-greeter/bug_1317236_default_image into lp:lightdm-gtk-greeter.

Requested reviews:
  LightDM Gtk+ Greeter Development Team (lightdm-gtk-greeter-team)
Related bugs:
  Bug #1317236 in lightdm-gtk-greeter (Ubuntu): "user supplied default-user-image does not display properly in lightdm-gtk-greeter"
  https://bugs.launchpad.net/ubuntu/+source/lightdm-gtk-greeter/+bug/1317236

For more details, see:
https://code.launchpad.net/~lightdm-gtk-greeter-team/lightdm-gtk-greeter/bug_1317236_default_image/+merge/219085

Bugfix for #1317236:

set_user_image() is not called if users list is hidden => default-user-image option is not applied to user_image
-- 
https://code.launchpad.net/~lightdm-gtk-greeter-team/lightdm-gtk-greeter/bug_1317236_default_image/+merge/219085
Your team LightDM Gtk+ Greeter Development Team is requested to review the proposed merge of lp:~lightdm-gtk-greeter-team/lightdm-gtk-greeter/bug_1317236_default_image into lp:lightdm-gtk-greeter.

=== modified file 'src/lightdm-gtk-greeter.c'
--- src/lightdm-gtk-greeter.c	2014-05-02 11:03:59 +0000
+++ src/lightdm-gtk-greeter.c	2014-05-10 00:49:23 +0000
@@ -727,11 +727,12 @@
 set_user_image (const gchar *username)
 {
     const gchar *path;
-    LightDMUser *user;
+    LightDMUser *user = NULL;
     GdkPixbuf *image = NULL;
     GError *error = NULL;
 
-    user = lightdm_user_list_get_user_by_name (lightdm_user_list_get_instance (), username);
+    if (username)
+        user = lightdm_user_list_get_user_by_name (lightdm_user_list_get_instance (), username);
     if (user)
     {
         path = lightdm_user_get_image (user);
@@ -2700,6 +2701,7 @@
     {
         /* Set the background to default */
         set_background (NULL);
+        set_user_image (NULL);
         start_authentication ("*other");
     }
     else