lightdm-gtk-greeter-team team mailing list archive

[Heinz Deinhart <w_ubuone@xxxxxx>]

Heinz Deinhart has proposed merging lp:~ennp/lightdm-gtk-greeter/lightdm-gtk-greeter-username-stripping into lp:lightdm-gtk-greeter.

Requested reviews:
  LightDM Gtk+ Greeter Development Team (lightdm-gtk-greeter-team)

For more details, see:
https://code.launchpad.net/~ennp/lightdm-gtk-greeter/lightdm-gtk-greeter-username-stripping/+merge/336613

Adds boolean config option username-strip-whitespace in greeter section. If set username will be stripped of whitespace.

Main reason: Quite some users tend to click away screensavers with the spacebar and then login fails because they do not notice the space in front of the user name.
-- 
Your team LightDM Gtk+ Greeter Development Team is requested to review the proposed merge of lp:~ennp/lightdm-gtk-greeter/lightdm-gtk-greeter-username-stripping into lp:lightdm-gtk-greeter.

=== modified file 'src/greeterconfiguration.h'
--- src/greeterconfiguration.h	2015-03-27 05:29:45 +0000
+++ src/greeterconfiguration.h	2018-01-25 14:47:17 +0000
@@ -26,6 +26,7 @@
 #define CONFIG_KEY_PANEL_POSITION       "panel-position"
 #define CONFIG_KEY_KEYBOARD_POSITION    "keyboard-position"
 #define CONFIG_KEY_A11Y_STATES          "a11y-states"
+#define CONFIG_KEY_USERNAME_STRIPPING   "username-strip-whitespace"
 
 #define CONFIG_GROUP_MONITOR            "monitor:"
 #define CONFIG_KEY_BACKGROUND           "background"

=== modified file 'src/lightdm-gtk-greeter.c'
--- src/lightdm-gtk-greeter.c	2017-09-23 01:20:34 +0000
+++ src/lightdm-gtk-greeter.c	2018-01-25 14:47:17 +0000
@@ -2179,6 +2179,15 @@
 gboolean
 username_focus_out_cb (GtkWidget *widget, GdkEvent *event, gpointer user_data)
 {
+    if (config_get_bool (NULL, CONFIG_KEY_USERNAME_STRIPPING, FALSE)) {
+	gchar *tmpstr = g_strdup( gtk_entry_get_text(username_entry));
+	
+	g_strstrip(tmpstr);
+	gtk_entry_set_text(username_entry, tmpstr);
+	g_free(tmpstr);
+    }
+     
+
     if (!g_strcmp0(gtk_entry_get_text (username_entry), "") == 0)
         start_authentication (gtk_entry_get_text (username_entry));
     return FALSE;