linux-traipu team mailing list archive

[Henrik Ingo <henrik.ingo@xxxxxxxxxxxxx>]

Hi. I tried to reply to this by email, but for some reason it is not
showing up here. Here it is:

On Sun, Mar 25, 2012 at 5:21 PM, Zisis Sialveras <zisis00@xxxxxxxxx> wrote:
>> -  N_("Authentication against an LDAP server"),
>> +  "LDAP based authenication.",
>>
>> Please don't change this. All authentication modules have a similar
>> description so stick to the style that's there.
>
> I can't really understand what you trying to say here. What (and where) is "LDAP based authentication" and "Authentication against an LDAP server" and when i change them ?
> Can you be more specific about this one, because it make no sense to me.

Please see the diff generated from your own commit:
http://bazaar.launchpad.net/~zisis00/drizzle/drizzle-fix-bug932837/revision/2535

Lines 460/484

In fact, it looks like you are changing back to an older version of
that line. Possibly this is because you've started developing your
code against a source tarball and then copied the file over to a later
position in the bzr trunk. In the future, please always start your
work with the "bzr branch" command and edit the files directly there,
then this kind of criss-cross error won't happen.

Anyway, you should just change that line so the _N(...) line is in
your auth_ldap.cc file. The one prepended with a minus above.

>> Please update the documentation in docs/index.rst. Since you seem to
>> know LDAP well, please do your best at writing something about the new
>> variable. If you don't know the RST syntax and/or don't like writing in
>> English, don't worry, I can help you later. But try to document what
>> each of the values for scope mean.
>
> I just wrote a briefly explanation about scope options and what is the functionality of each one.
> The truth is that i am not used to RST syntax, but i think i can understand it just from watching the index.rst. - I think i wrote it correctly.
> Where should i test it though ? And if it is indeed correct, should i push the changes ?
>

If you do "make html" it will try to compile html pages of all rst
documentation. You will probably get several syntax errors, then fix
and repeat. And yes, when done you bzr commit and bzr push.

Also just in general you should have a habit of doing "make test"
before pushing or at least before you send a merge request. make test
also will include a run of make html. Of course, since auth_ldap
doesn't have any tests, this isn't helpful in this case.

henrik

-- 
You received this bug notification because you are a member of UBUNTU -
AL - BR, which is subscribed to Drizzle.
https://bugs.launchpad.net/bugs/932837

Title:
  FEATURE REQUEST: Add "wholeSubtree search capabilities in auth-ldap

Status in A Lightweight SQL Database for Cloud Infrastructure and Web Applications:
  Fix Committed

Bug description:
  Currently the auth-ldap only supports singleLevel search
  (LDAP_SCOPE_ONELEVEL) which is not very useful for organisations with
  complicated structure. For example in our university each department
  has it's own OU and the users lie under their respective OUs. So there
  is a need for hierarchical searching under a common Base-Dn

  According to the auth-ldap doc page:

  "The option LDAP_SCOPE_ONELEVEL option is used when searching the LDAP
  directory. This means you must specify the full base-dn. For instance,
  if you have users defined in the dn ou=people,dn=example,dn=com
  authentication will fail if you only specify dn=example,dn=com. A
  consequence of this is that all your Drizzle users must belong to the
  same LDAP organizationalUnit.

  This is currently a fixed option and can only be changed by editing
  source code. However, there is no reason why it couldn’t be a
  configurable option to also allow multi level searches. Please contact
  the Drizzle developers if you have such needs. (See Help and Support)"

  So here I am requesting for multi level searches (wholeSubtree)
  support for auth-ldap if  it's not to hard to implement.

To manage notifications about this bug go to:
https://bugs.launchpad.net/drizzle/+bug/932837/+subscriptions