linux-traipu team mailing list archive

[Daniel Ellis <mail@xxxxxxxxxxxxxx>]

So that other patch was fine, the reason it caused issues for video
clips was because all imported video clips have their max_frames
property 1 less than they should be.  The attached patch fixes this.

However the piece of code that determines the max_frames property is
only run when the clip is imported.  When you open an existing project,
I think the value is deserialised, and so existing projects will still
have the incorrect values.

To resolve this I think we will need to add a routine to update the
max_frames property when the project is opened.  That would be extra
overhead that I guess we would prefer to avoid every time the project is
opened.  Alternatively we could use a file format version stored in the
project file to run an upgrade routine when things like this need to be
done.  Does a routine like this exist already?

** Patch added: "fix_max_frames_length.patch"
   https://bugs.launchpad.net/openshot/+bug/1013035/+attachment/3190025/+files/fix_max_frames_length.patch

-- 
You received this bug notification because you are a member of UBUNTU -
AL - BR, which is subscribed to OpenShot Video Editor.
https://bugs.launchpad.net/bugs/1013035

Title:
  Fade glitches caused by "out" attribute being greater than clip length

Status in OpenShot Video Editor:
  New

Bug description:
  Continuing from bug #520941.  I have found another scenario which can
  cause glitches with fade when using an imported PNG sequence.  The
  generated XML includes and out attribute which is longer than the
  clip, which causes problems for the rest of the timeline.

  The issue affects 1.4.2 and trunk.

  Attached is a simple patch (agains trunk) which solves the issue.

  The code previously had three branches, but note that the first two
  branches where the same, so I have changed this to a simple if/else
  with just the two relavent branches, as well as fixing the out number
  which was off by 1.

To manage notifications about this bug go to:
https://bugs.launchpad.net/openshot/+bug/1013035/+subscriptions