linuxdcpp-team team mailing list archive

[noreply@xxxxxxxxxxxxx]

------------------------------------------------------------
revno: 348
committer: Steven Sheehy <steven.sheehy@xxxxxxxxx>
branch nick: trunk
timestamp: Sat 2010-01-30 21:49:41 -0600
message:
  Fixed a crash in debug builds due to bad nick conversion handling
modified:
  Changelog.txt
  dcpp/ClientManager.cpp


--
lp:linuxdcpp
https://code.launchpad.net/~linuxdcpp-team/linuxdcpp/trunk

Your team LinuxDC++ Team is subscribed to branch lp:linuxdcpp.
To unsubscribe from this branch go to https://code.launchpad.net/~linuxdcpp-team/linuxdcpp/trunk/+edit-subscription.

=== modified file 'Changelog.txt'
--- Changelog.txt	2010-01-07 19:49:29 +0000
+++ Changelog.txt	2010-01-31 03:49:41 +0000
@@ -41,6 +41,7 @@
 [2009-11-25] Added issue with MacPorts boost lib not being detected on OS X to Readme. (thanks vszakats)
 [2009-12-31] lp#397365: Fixed sorting of "Time Left" column in transfers view. (Steven)
 [2010-01-07] lp#473173: Crash when hashing files. Added missing SIGBUS handler. (Razzloss)
+[2010-01-30] lp#321246: Fixed a crash in debug builds due to bad nick conversion handling. (Steven)
 
 *** 1.0.3 2009-02-01 ***
 [2008-08-10] lp#256236: Fixed a crash on startup when using auto-open options.

=== modified file 'dcpp/ClientManager.cpp'
--- dcpp/ClientManager.cpp	2009-08-15 04:40:26 +0000
+++ dcpp/ClientManager.cpp	2010-01-31 03:49:41 +0000
@@ -182,8 +182,10 @@
 }
 
 UserPtr ClientManager::findLegacyUser(const string& aNick) const throw() {
+	if (aNick.empty())
+		return UserPtr();
+
 	Lock l(cs);
-	dcassert(aNick.size() > 0);
 
 	for(OnlineMap::const_iterator i = onlineUsers.begin(); i != onlineUsers.end(); ++i) {
 		const OnlineUser* ou = i->second;