← Back to team overview

linuxdcpp-team team mailing list archive

[Bug 517948] Re: Memory leak while hashing

 

After looking at the code and discussing with Razzloss, we don't see a
memory leak here. Your patch will actually cause it to try to unmap the
same memory twice. The one thing that was wrong with the code was an
extra iteration in the fast hash loop that I fixed in revision 351. This
extra iteration would not cause an extra mmap though due to the
if(size_left > 0) check.

Are you sure you're getting a memory leak? If so, are you able to verify
it (say using a memory leak detector)? Can you try with the latest
revision?

** Changed in: linuxdcpp
       Status: Confirmed => Incomplete

** Changed in: linuxdcpp
    Milestone: 1.1.0 => None

-- 
Memory leak while hashing
https://bugs.launchpad.net/bugs/517948
You received this bug notification because you are a member of LinuxDC++
Team, which is subscribed to LinuxDC++.

Status in Linux DC++: Incomplete

Bug description:
Looks like memory mappings are destroyed on Linux when the file descriptor is closed. This is not the case on FreeBSD.

Please see attached patch.





References