linuxdcpp-team team mailing list archive

[eMTee <emtee11@xxxxxxxxx>]

We don't use the FileFindIter to examining files here. We instantiate it
because it has code ready for checking hidden status of a folder, and
that's what we use it for here (because there's no such function in the
File class).

Yes, other code in ShareManager which examining >files< for sharing uses
the method mentioned above. I can't see any connection with your comment
and the problem here.

-- 
Its not possible to share a whole drive in random cases
https://bugs.launchpad.net/bugs/556853
You received this bug notification because you are a member of
Dcplusplus-team, which is subscribed to DC++.

Status in DC++: Confirmed
Status in StrongDC++: New

Bug description:
The problem hits 0.67x and is because the FileFindIter class does not like if the given path is a root folder of a drive. If it created by passing a <drive:>\ like (or any other invalid) format to the constructor then the DirData structure member functions' retrurning values are computed on random memory content. isHidden() returns mostly false but not always as many reported :)

The attached patch can solve the problem, and with a quick look to the non-win32 part of the FileFindIter class, I think it should not hurt the *nix side, either.