linuxdcpp-team team mailing list archive

[Big Muscle <bigmuscle@xxxxxxxxxx>]

True, attribute of root folder can't be set. However, I still don't see
attached patch correct. Since some variables are not initialized, their
value can be completely random. And randomness can cause that the patch
will work randomly. In other words, "ff != FileFindIter()" will work
only if ff and FileFindIter has unitialized variables set to same value.

-- 
Its not possible to share a whole drive in random cases
https://bugs.launchpad.net/bugs/556853
You received this bug notification because you are a member of
Dcplusplus-team, which is subscribed to DC++.

Status in DC++: Confirmed
Status in StrongDC++: New

Bug description:
The problem hits 0.67x and is because the FileFindIter class does not like if the given path is a root folder of a drive. If it created by passing a <drive:>\ like (or any other invalid) format to the constructor then the DirData structure member functions' retrurning values are computed on random memory content. isHidden() returns mostly false but not always as many reported :)

The attached patch can solve the problem, and with a quick look to the non-win32 part of the FileFindIter class, I think it should not hurt the *nix side, either.