linuxdcpp-team team mailing list archive

[poy <poy@xxxxxxxxxx>]

** Changed in: adchpp
       Status: Fix Committed => Fix Released

-- 
PING bugs
https://bugs.launchpad.net/bugs/474927
You received this bug notification because you are a member of
Dcplusplus-team, which is subscribed to ADCH++.

Status in ADCH++: Fix Released

Bug description:
Im not that good with lua, but as i see it this piece of code requires PING support to be set to the client already:

local function onSUP(c, cmd)
	if c:getState() ~= adchpp.Entity_STATE_PROTOCOL or not c:hasSupport(adchpp.AdcCommand_toFourCC("PING")) then
		-- let ClientManager verify this SUP
		return true
	end


and if it is in STATE_PROTOCOL  and verifySUP has not been called yet, supports would be empty.


Also should not the hub reply with TYPE_INFO instead of TYPE_HUB?
-> c:send(adchpp.AdcCommand(adchpp.AdcCommand_CMD_SID, adchpp.AdcCommand_TYPE_INFO, adchpp.AdcCommand_HUB_SID)