← Back to team overview

linuxdcpp-team team mailing list archive

[Bug 326541] Re: Request for more filtering options on search

 

Ok here is a patch proposal for configurable search types for ADC using the EX parameter of SCH command while still retaining the current way of search for NMDC. 
This adds 5 predefined search type groups as in SearchManager::TypeModes and gives possibility to add unlimited number of user-defined types. There's a new pane in Settings to manage them. It stores the extension list in DCPlusPlus.xml in an ID - extensionlist pair format. ID is a name given by the user for user-defined types, for predefined types the ID is the corresponding enum in SearchManager::TypeModes and the GUI should show their predefined translated name for them.
At the time of search if a predefined type selected, it will send the defined extension list with SCH in ADC hubs and will do the same as before in NMDC hubs. If user-defined search type selected, it works on ADC only, for NMDC hubs it'll send TYPE_ANY with the search request.
Predefined types can't be deleted atm, this can be allowed later when NMDC support is dropped.
Please comment.

** Patch added: "searchtypes.patch"
   http://launchpadlibrarian.net/49829364/searchtypes.patch

-- 
Request for more filtering options on search
https://bugs.launchpad.net/bugs/326541
You received this bug notification because you are a member of
Dcplusplus-team, which is subscribed to DC++.

Status in DC++: New

Bug description:
It would be a really handy feature to define own "filetype" filters.

For example we do have a file tye "archive" that would give you only zip, rar, ace and lzh-Files.
It would be really cool to add mx own types like for comics: cbr, cbz, cba, ace, zip, rar, lzh and folders.
So that I don't have to scroll trough endless lists of mp3 . . .

As far as i have been told is that an idea that would require changes in the protocol or the hub software, so I suggest an additional local filter: Search for all files on the hub, but show only . . .

Thanx for a great software!
mabuse