linuxdcpp-team team mailing list archive

[Crise <markuwil@xxxxxxxxx>]

Pardon me, but I was not arguing against DC++ naming standards, I was
simply stating my reasons for naming them the way I did. Besides (if it
is decided that this gets into DC++) you don't need me to change some
capitalisations, anyone can do that since I won't be the one putting it
in anyways as I don't have any access to the repository.

Regarding the ACP stuff I do see your point and that is easy to sort
out. But if the API provides text conversions it is only logical to
provide utf-8 to wide char conversion as well if unix does not need this
then it's no-ones loss.

Regarding your comment about onOutgoingChat, sure that might be partly
true but the idea of onOutgoingChat & co. is to allow plugins to react
to outgoing chat before UI does anything with it. If you want it is easy
enough to change it to something like onPreprocessChat and move the hook
event(s) under the UI hook id.

One scenario that mandates onOutgoingChat be called from UI is the case
where plugin wants to extend an existing client side command for example
(/help being the first one that comes to mind).

There are some other things that have come up in recent(ish) discussions
about the implementation anyways, so I'll be updating the patch soon.

-- 
Plugins support
https://bugs.launchpad.net/bugs/587597
You received this bug notification because you are a member of
Dcplusplus-team, which is subscribed to DC++.

Status in DC++: New

Bug description:
Ok, I'll leave out the sales pitch... here is a potential patch for adding support for plugins to DC++, compiles cleanly (ie. shouldn't generate any warnings) under mingw and visual studio of course and has been tested and working.

The code itself has been in ApexDC++ for a while so it has gotten real life use as well, of course migrating it to clean DC++ needed a few changes here and there but nothing major.

Should also compile and work on linux as it is... but this I have not had chance to test at all so that is just on paper for now.

The major difference between this patch and what's in ApexDC++ is that it does not include a full settings page for plugins which ApexDC++ has. This is simply because I don't know a squat about DWT. Instead this patch has set of chat commands added, so you can play around with the plugins, but if this gets accepted then I certainly hope someone is willing to invest into a settings page for usability sake.

Oh and few changes to the code come directly from bcdcpp, you'll spot them I am sure :).

As for the plugins currently three exists.. a pure C sample that (you guessed it) really doesn't do anything productive and then a plugin version of bcdcpp's lua (this one is pretty direct port, so it is C++).

The third one is not so impressive... it adds support for various media player chat announces (spam is too negative of a word), although primarily I created it to proof that it is possible to make a plugin that modifies the GUI, even though the API itself has little to no support for such plugin (on windows anyways),

The first two plugins can be compiled with both mingw and visual studio and are also hopefully linux friendly, the third not so much.

Oh and you can mix plugins... so mingw compiled dcpp will cope just fine with visual studio compiled plugins or vice versa (obviously this also means that the stl's used can be different). In theory you should also be able to create plugins with languages such as VB and Delphi but this very much theoretical.

Well do what you want with it... it's posted now.